-
Notifications
You must be signed in to change notification settings - Fork 5
Migrate to TanStack Start RC #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| declare module '@tanstack/react-router' { | ||
| interface Register { | ||
| router: ReturnType<typeof createRouter> | ||
| router: ReturnType<typeof getRouter> | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it matters, but this isn't present when creating a new Tanstack app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the updated one
src/routes/index.tsx
Outdated
| <SignedOut> | ||
| <p>You are signed out</p> | ||
| <SignInButton /> | ||
| <SignInButton mode="modal" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't in the quickstart changes from this PR: clerk/clerk-docs#2690
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, ty!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!

No description provided.