Skip to content

Conversation

@wobsoriano
Copy link
Member

No description provided.

Comment on lines 16 to 19
declare module '@tanstack/react-router' {
interface Register {
router: ReturnType<typeof createRouter>
router: ReturnType<typeof getRouter>
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it matters, but this isn't present when creating a new Tanstack app.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the updated one

<SignedOut>
<p>You are signed out</p>
<SignInButton />
<SignInButton mode="modal" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't in the quickstart changes from this PR: clerk/clerk-docs#2690

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, ty!

Copy link

@SarahSoutoul SarahSoutoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments! LGTM overall. Think we should update the Introduction on the README too, as it mentions the old createClerkHandler stuff.

Screenshot 2025-10-14 at 1 13 19 pm

@wobsoriano wobsoriano marked this pull request as ready for review October 14, 2025 20:56
Copy link

@SarahSoutoul SarahSoutoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wobsoriano wobsoriano merged commit d60718a into main Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants